Alona Kaplan has posted comments on this change. Change subject: engine: blocking unlinking of passthrough vnic ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38889/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java: Line 152: private boolean validateNics(List<VmNic> interfaces, Line 153: Version clusterCompatibilityVersion) { Line 154: for (VmNic iface : interfaces) { Line 155: VmNicValidator nicValidator = new VmNicValidator(iface, clusterCompatibilityVersion); Line 156: if (!parentCommand.validate(nicValidator.emptyNetworkValid()) || !parentCommand.validate(nicValidator.linkedOnlyIfSupported())) { > please use formatter, line is too long. Done Line 157: return false; Line 158: } Line 159: } Line 160: -- To view, visit https://gerrit.ovirt.org/38889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbb89bcdc1af6b87b8e1e04c52424ca282db7222 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
