Eli Mesika has posted comments on this change. Change subject: Don't add the cdrom device if iso_path is empty ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java Line 151: struct = new XmlRpcStruct(); Line 152: String cdPath = vm.getCdPath(); Line 153: addCdDetails(vmDevice, struct); Line 154: addAddress(vmDevice, struct); Line 155: addDevice(struct, vmDevice, cdPath == null ? "" : cdPath); Talked with shavivi , this may affect the payload, please do not submit this patch without pre-integration phase on the payload to verify that we don't have regressions Line 156: break; // currently only one is supported, may change in future releases Line 157: } Line 158: } Line 159: } -- To view, visit http://gerrit.ovirt.org/8092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cb5631a16a322bda1e371efce5c318f666b1d0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
