Francesco Romani has posted comments on this change. Change subject: userportal, webadmin: VM console key management ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/35810/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java: Line 2485: onRestoreFromExportDomain(); Line 2486: } Line 2487: }) Line 2488: .setTitle(ConstantsManager.getInstance().getConstants().ok()) Line 2489: .setIsDefault(true) > Not sure if it is just gerrit but the indentations between lines 2488-2505 Will fix (here and below). Strange that CI is not screaming about this :\ Line 2490: ); Line 2491: Line 2492: model.getCommands().add(new UICommand(CMD_BACK, new BaseCommandTarget() { Line 2493: @Override https://gerrit.ovirt.org/#/c/35810/9/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java: Line 97: return newVmPopupProvider.get(); Line 98: } Line 99: } else if (lastExecutedCommand == getModel().getSetConsoleKeyCommand()) { Line 100: return publicKeyPopupProvider.get(); Line 101: } else if (lastExecutedCommand == getModel().getNewVmCommand()) { > These two branches for newVm and Edit commands seems to be dead code since will check and possibly remove Line 102: return newVmPopupProvider.get(); Line 103: } else if (lastExecutedCommand == getModel().getEditCommand()) { Line 104: return newVmPopupProvider.get(); Line 105: } else if (windowModel instanceof VncInfoModel) { -- To view, visit https://gerrit.ovirt.org/35810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2364cafc687ba6dee2504322234067ff98dc00c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
