Yair Zaslavsky has posted comments on this change.
Change subject: core: using pg_dump --column-inserts ...(#858643)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File backend/manager/dbscripts/backup.sh
Line 64: file="${DIR}/${file}"
Line 65: fi
Line 66:
Line 67: if [ -n "${COLUMN_INSERTS}" ]; then
Line 68: cmd="pg_dump -C -E UTF8 --column-inserts --disable-dollar-quoting
--disable-triggers --format=p -h ${SERVERNAME} -p ${PORT} -U ${USERNAME} -f
${file} ${DATABASE}"
If this is the only difference, can't we simply concatenate a variable that
will either be an empty string or will be "--column-inserts"?
Line 69: else
Line 70: cmd="pg_dump -C -E UTF8 --disable-dollar-quoting
--disable-triggers --format=p -h ${SERVERNAME} -p ${PORT} -U ${USERNAME} -f
${file} ${DATABASE}"
Line 71:
Line 72: fi
--
To view, visit http://gerrit.ovirt.org/8134
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac6b8a6762868b9535f24cc9c496e11722485885
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
