Michael Kublin has posted comments on this change.
Change subject: core: Auto-Recovery should check whether getVdsStats returns
'lastCheck<60' before it proclaims host as up (#844438)
......................................................................
Patch Set 1: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 167: boolean returnValue = true;
Line 168: try {
Line 169: runVdsCommand(VDSCommandType.GetStats, new
VdsIdAndVdsVDSCommandParametersBase(getVds()));
Line 170: if
(IrsBrokerCommand.isDomainsReportedAsProblematic(getVds().getstorage_pool_id(),
getVds().getDomains())) {
Line 171: log.errorFormat("One of the domains of host {0} in
pool {1} is problematic",
Done
Line 172: getVds().getvds_name(),
Line 173: getStoragePool()
Line 174: .getname());
Line 175: returnValue = false;
Line 174: .getname());
Line 175: returnValue = false;
Line 176: }
Line 177: } catch (VdcBLLException e) {
Line 178: log.errorFormat("Could not get vds stats for vds {0}
because of error {1}",
Done
Line 179: getVds().getvds_name(),
Line 180: e);
Line 181: returnValue = false;
Line 182: }
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 357: VDS_CPU_LOWER_THAN_CLUSTER=Host ${VdsName} moved to Non-Operational
state as host does not meet the cluster's minimum CPU level. Missing CPU
features : ${CpuFlags}
Line 358: CPU_FLAGS_NX_IS_MISSING=Host ${VdsName} is missing the NX cpu flag.
This flag can be enabled via the host BIOS. Please set Disable Execute (XD) for
an Intel host, or No Execute (NX) for AMD. Please make sure to completely
power off the host for this change to take effect.
Line 359: VDS_CPU_RETRIEVE_FAILED=Failed to determine Host ${VdsName} CPU level
- could not retrieve CPU flags.
Line 360: VDS_STORAGE_CONNECTION_FAILED_BUT_LAST_VDS=Failed to connect Host
${VdsName} to Data Center, due to connectivity errors with the Storage. Host
${VdsName} will remain in Up state (but inactive), as it is the last Host in
the Data Center, to enable manual intervention by the Administrator.
Line 361: VDS_STORAGE_VDS_STATS_FAILED=Host ${VdsName} reports about one of the
active domains as problematic.
Done
Line 362: VDS_SET_NONOPERATIONAL=Host ${VdsName} moved to Non-Operational state.
Line 363: VDS_SET_NONOPERATIONAL_FAILED=Failed to move Host ${VdsName} to
Non-Operational state.
Line 364: VDS_FENCE_STATUS=Host ${VdsName} power management was verified
successfully.
Line 365: VDS_FENCE_STATUS_FAILED=Failed to verify Host ${VdsName} power
management.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1112: logDelayedDomain(vdsId, tempData);
Line 1113: }
Line 1114: } else if
(inActiveDomainsInPool.contains(tempData.getDomainId())
Line 1115: &&
!isDomainReportedAsProblematic(tempData, false)) {
Line 1116: log.warnFormat("Storage {0} was reported
by vds {1} as active in pool {2}, moving to active status",
Done
Line 1117: tempData.getDomainId(),
Line 1118: vdsName,
Line 1119: _storagePoolId);
Line 1120: storage_pool_iso_map map =
Line 1179: }
Line 1180: domainsInPool.removeAll(domainWhicWereSeen);
Line 1181: if (domainsInPool.size() > 0) {
Line 1182: for (Guid domainId : domainsInPool) {
Line 1183: log.errorFormat("Domain {0} was not seen by
host", domainId);
Done
Line 1184: }
Line 1185: return true;
Line 1186: }
Line 1187: return false;
Line 1198: }
Line 1199: if (tempData.getLastCheck() > Config
Line 1200: .<Double>
GetValue(ConfigValues.MaxStorageVdsTimeoutCheckSec)) {
Line 1201: if (isLog) {
Line 1202: log.errorFormat("Domain {0} was reported with
too big lastCheck {1}",
Done
Line 1203: tempData.getDomainId(),
Line 1204: tempData.getLastCheck());
Line 1205: }
Line 1206: return true;
--
To view, visit http://gerrit.ovirt.org/8131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id88ef24829d5fae61dddd34f0265ae3132672783
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
