Allon Mureinik has posted comments on this change. Change subject: core: initializing domain sizes with null ......................................................................
Patch Set 13: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/39028/13/packaging/dbscripts/upgrade/03_06_1200_set_third_party_storage_size_to_NA.sql File packaging/dbscripts/upgrade/03_06_1200_set_third_party_storage_size_to_NA.sql: Line 1: UPDATE storage_domain_dynamic This file was added in the previous patch. Why rename it here? Why not just add it with the right name? Line 2: SET available_disk_size = NULL, used_disk_size = NULL Line 3: FROM storage_domain_static, providers Line 4: WHERE storage_domain_dynamic.id = storage_domain_static.id AND Line 5: storage_domain_static.storage = CAST(providers.id AS VARCHAR) AND -- To view, visit https://gerrit.ovirt.org/39028 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182a4c25ed0bf896adaadb86e8b36cfaf17d93e6 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
