Alona Kaplan has posted comments on this change. Change subject: webadmin: fluent UiAction ......................................................................
Patch Set 19: (1 comment) https://gerrit.ovirt.org/#/c/36848/19/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/action/UiAction.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/action/UiAction.java: Line 98: * Line 99: * @param actionFlowState Line 100: * the state of the flow this action wants to join. Line 101: */ Line 102: public void runAction(ActionFlowState actionFlowState) { > Why do you run the vfsConfig action flow serially (i.e. using then()) after I want the actions within vfsConfigAction to run only if (and after) the CommitNetworkChangesAction succeeds. Line 103: actionFlowState.setValue(actionFlowState.getValue() + 1); Line 104: runActionNoStateIncrease(actionFlowState); Line 105: } Line 106: -- To view, visit https://gerrit.ovirt.org/36848 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I262282d00bbb16a65f36a2463d3ffe8dbf6594c6 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
