Allon Mureinik has posted comments on this change. Change subject: core: Quota consumption for Vm's disk updating refactor. ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39398/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 704: } Line 705: } Line 706: Line 707: // Generate a RELEASE request Line 708: if (doesOldDiskHadQuota && isQuotaChanged) { > It seems that the infra handles null quota only in the CONSUME part, This c Why not just fix the infra? Line 709: list.add(generateQuotaRequestParameters(oldDiskImage, Line 710: QuotaConsumptionParameter.QuotaAction.RELEASE, Line 711: oldDiskImage.getSizeInGigabytes())); Line 712: } -- To view, visit https://gerrit.ovirt.org/39398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I838973e9f1e71d36193fb2ea832b18b9308c7248 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
