Alona Kaplan has uploaded a new change for review.

Change subject: engine: lefteover from adding HOST_DEVICE to VmDeviceGeneralType
......................................................................

engine: lefteover from adding HOST_DEVICE to VmDeviceGeneralType

VmDeviceGeneralType- this code should never be reached.
Updated it just for consistency.
OvfReader- fix small inaccuracy in the comment

Change-Id: I28a90d68e0a17059c04567e228c01fb1498eabbd
Signed-off-by: Alona Kaplan <alkap...@redhat.com>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java
M 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/93/39693/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java
index d917b63..7280c0b 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java
@@ -130,6 +130,7 @@
 
             case INTERFACE:
             case BRIDGE:
+            case HOST_DEVICE:
                 type = INTERFACE;
                 break;
 
diff --git 
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
 
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
index f48500b..790eb4d 100644
--- 
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
+++ 
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
@@ -901,7 +901,7 @@
                 
vmDevice.setDevice(VmDeviceType.getoVirtDevice(resourceType).getName());
             }
         } else if (Integer.valueOf(OvfHardware.Network) == resourceType) {
-            // handle interfaces with different sub types : we have 0-3 as the 
VmInterfaceType enum
+            // handle interfaces with different sub types : we have 0-5 as the 
VmInterfaceType enum
             VmInterfaceType nicType = 
VmInterfaceType.forValue(resourceSubType);
             if (nicType != null) {
                 if (nicType == VmInterfaceType.pciPassthrough) {


-- 
To view, visit https://gerrit.ovirt.org/39693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28a90d68e0a17059c04567e228c01fb1498eabbd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to