ofri masad has uploaded a new change for review. Change subject: core: Fix NPE in QuotaManager (#855647) ......................................................................
core: Fix NPE in QuotaManager (#855647) https://bugzilla.redhat.com/855647 Added Null check to the decreaseStorageQuota() method. Change-Id: I6354767e93b5066d4eb167ff8744c1daed18e351 Signed-off-by: Ofri Masad <oma...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/8127/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java index df8881e..b852998 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java @@ -130,6 +130,13 @@ List<StorageQuotaValidationParameter> parameters) { lock.readLock().lock(); try { + if (storagePool == null){ + log.debug("Null storage pool was passed to 'QuotaManager.decreaseStorageQuota()'"); + if (parameters.isEmpty() || parameters.get(0).getQuotaId() == null) { + return; + } + storagePool = extractStoragePoolFromQuota(parameters.get(0).getQuotaId()); + } if (!storagePoolQuotaMap.containsKey(storagePool.getId())) { return; } -- To view, visit http://gerrit.ovirt.org/8127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6354767e93b5066d4eb167ff8744c1daed18e351 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
