Alona Kaplan has posted comments on this change.

Change subject: engine: Cleanup the vfs when the vm is down
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38624/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java:

Line 109: 
Line 110:     private void cleanupVfs() {
Line 111:         Guid hostId = 
hostNicVfsConfigHelper.removeVmIdFromVfs(getVmId());
Line 112: 
Line 113:         // refresh host network interfaces to get the VFs that were 
detached from the VM and re-attached to the host
> can you point me to where the VFs are being detached from the VM and attach
when the vdsm stops the vms.
Line 114:         if (hostId != null) {
Line 115:             VDS host = DbFacade.getInstance().getVdsDao().get(hostId);
Line 116: 
Line 117:             
resourceManager.runVdsCommand(VDSCommandType.CollectVdsNetworkData,


-- 
To view, visit https://gerrit.ovirt.org/38624
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1f861a451f4e0961ec122e4c2594081ea6dc71b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to