Martin Betak has posted comments on this change. Change subject: frontend: Add infrastructure for Console Foreign Menu ......................................................................
Patch Set 7: (4 comments) https://gerrit.ovirt.org/#/c/38986/7/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractConsole.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractConsole.java: Line 2: Line 3: import com.google.inject.Inject; Line 4: import org.ovirt.engine.ui.uicommonweb.ConsoleUtils; Line 5: Line 6: public class AbstractConsole { > Maybe mark this class as abstract? Done Line 7: @Inject Line 8: protected ConsoleUtils consoleUtils; https://gerrit.ovirt.org/#/c/38986/7/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractRdp.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractRdp.java: Line 2: Line 3: import org.ovirt.engine.ui.frontend.Frontend; Line 4: Line 5: Line 6: public class AbstractRdp extends AbstractConsole { > Maybe mark this class as abstract? Done Line 7: private String address; Line 8: private String guestID; Line 9: Line 10: private Boolean fullScreen = true; https://gerrit.ovirt.org/#/c/38986/7/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java: Line 21: Line 22: @Inject Line 23: private Configurator configurator; Line 24: @Inject Line 25: private ConsoleUtils cu; > Is this field still needed? (there's already the protected "consoleUtils" f Done Line 26: private final ClientAgentType cat = new ClientAgentType(); Line 27: Line 28: @Override Line 29: public void invokeClient() { https://gerrit.ovirt.org/#/c/38986/7/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java: Line 3: import org.ovirt.engine.core.compat.Guid; Line 4: import org.ovirt.engine.ui.common.uicommon.AbstractConsole; Line 5: import org.ovirt.engine.ui.uicommonweb.restapi.HasForeignMenuData; Line 6: Line 7: public class AbstractConsoleWithForeignMenu extends AbstractConsole implements HasForeignMenuData { > Maybe mark this class as abstract? Done Line 8: private String sessionId; Line 9: private Guid vmId; Line 10: private String engineHost; Line 11: private boolean admin; -- To view, visit https://gerrit.ovirt.org/38986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0cc2a2fd462bd8dc9085b300ec12fe46ff4518 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
