Eliraz Levi has posted comments on this change. Change subject: webadmin: adding network-out-of-sync to SubTabNetworkHost ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38291/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java: Line 77: Grid row = Line 78: createVlanRowColumn(checkboxPanel, Line 79: hostVLan.getInterface().getIsManagement(), Line 80: hostVLan.getNetworkName(), Line 81: createSyncPanel(hostVLan.getInterface().getNetworkImplementationDetails().isInSync()), > It's strange to me that here you don't have to consider the null implementa possible indeed. NPE is possible in case a user set a VLan and deleted the network on top. didn't thought it will happened as how come a VLan can function with no network configure on top. modified as requested. Line 82: new Label(hostVLan.getAddress())); Line 83: Line 84: Style gridStyle = row.getElement().getStyle(); Line 85: gridStyle.setBorderColor("white"); //$NON-NLS-1$ -- To view, visit https://gerrit.ovirt.org/38291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id200f9c135f1097572feac300e255a438cfb295a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
