Alon Bar-Lev has posted comments on this change. Change subject: hosted-engine: configure gluster for HC ......................................................................
Patch Set 1: (1 comment) once again we should discuss the modifying of system state by this and not reverting when not installed. can't it dynamically being set if required? why do we force a specific port and not leave the default? https://gerrit.ovirt.org/#/c/39678/1/src/plugins/ovirt-host-deploy/hosted-engine/glusterd.py File src/plugins/ovirt-host-deploy/hosted-engine/glusterd.py: Line 65: continue Line 66: elif line.find('end-volume') == 0: Line 67: content.append(' option rpc-auth-allow-insecure on') Line 68: content.append(' option base-port 49217') Line 69: content.append(line) I do not know what format this file has, but comments and such should be managed. Line 70: Line 71: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 72: filetransaction.FileTransaction( Line 73: name=odeploycons.FileLocations.GLUSTERD_VOL, -- To view, visit https://gerrit.ovirt.org/39678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bded0891309a2d38daef76bac93c7c7a4b0602a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Vijay Bellur <vbel...@gmail.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
