Tal Nisan has posted comments on this change. Change subject: webadmin: Show data center name in add storage domain task info ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39611/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 1107: parameters.add(new StorageServerConnectionParametersBase(this.connection, host.getId())); Line 1108: StorageDomainManagementParameter parameter = new StorageDomainManagementParameter(storageDomain); Line 1109: parameter.setVdsId(host.getId()); Line 1110: StoragePool dataCenter = model.getDataCenter().getSelectedItem(); Line 1111: parameter.setStoragePoolId(dataCenter.getId()); > is it displayed correctly when datacenter is '(none)'? Yes, that was the first thing I verified, was afraid we might get an NPE or something Line 1112: parameters.add(parameter); Line 1113: Line 1114: IFrontendActionAsyncCallback callback1 = new IFrontendActionAsyncCallback() { Line 1115: @Override -- To view, visit https://gerrit.ovirt.org/39611 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76f32f1bc2050c05f6396370d1302dcf2f9e3e78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
