Alon Bar-Lev has posted comments on this change. Change subject: services, setup: ovirt-vmconsole integration ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/35906/6/packaging/services/ovirt-vmconsole-proxy/ovirt-vmconsole-list-consoles.in File packaging/services/ovirt-vmconsole-proxy/ovirt-vmconsole-list-consoles.in: > For my understanding: config.py can reside at same directory, no need to any path mangling. from . import config the benefit is that the python code is pure and not generated, keeping executable bits, and checked using the pyflakes/pep8 properly without abnormalities. Line 1: #!/usr/bin/env python Line 2: # Line 3: # Copyright 2015 Red Hat Line 4: # https://gerrit.ovirt.org/#/c/35906/6/packaging/services/ovirt-vmconsole-proxy/ovirt-vmconsole-list-keys.in File packaging/services/ovirt-vmconsole-proxy/ovirt-vmconsole-list-keys.in: > I prefer 2 or 3, will go 1 as fallback. ok, no need fallback... just implement 2 Line 1: #!/usr/bin/env python Line 2: # Line 3: # Copyright 2015 Red Hat Line 4: # -- To view, visit https://gerrit.ovirt.org/35906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034ef8e6d10da5dc93eda61e0c5c518ca13a5a28 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
