Simone Tiraboschi has uploaded a new change for review. Change subject: packaging: setup: fixing RunningCommands type ......................................................................
packaging: setup: fixing RunningCommands type Further code expects a list of running task or command or compesation. If command table doesn't exist on the system we are going to upgrade we were passing a Null value that was going to break other code. Returning an empty list to make it more consistent. Change-Id: I5b8f03ce655d1a9f450dd79b438a1ef9540f7b29 Bug-Url: https://bugzilla.redhat.com/1197616 Signed-off-by: Simone Tiraboschi <stira...@redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/39664/1 diff --git a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py index 1b4ccaf..c4a5024 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py +++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py @@ -229,7 +229,7 @@ def _getRunningCommands(self, dbstatement): if not self._getCommandEntitiesTableExists(dbstatement): - return None + return [] commands = dbstatement.execute( statement=""" -- To view, visit https://gerrit.ovirt.org/39664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5b8f03ce655d1a9f450dd79b438a1ef9540f7b29 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
