Vered Volansky has uploaded a new change for review. Change subject: core:Changed illegal error msg to locked (#840304) ......................................................................
core:Changed illegal error msg to locked (#840304) https://bugzilla.redhat.com/840304 Replaced VM in illegal state error message to locked VM in: ImagesHandler.PerformImagesChecks() when the VM is indeed locked. The specific flow of actions to introduce the wrong message was: Try to export a VM while committing a preview. This yielded a statement that the VM's state is illegal while it should only say that it's locked. This should correct other flow of events as well. Change-Id: I2edb7b8c946589f3bbad251d533704fe856bc175 Signed-off-by: Vered Volansky <vvola...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/78/8078/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java index 0657032..ff5171d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java @@ -462,7 +462,7 @@ if (returnValue && checkImagesLocked) { List<String> lockedDisksAliases = new ArrayList<String>(); if (vm.getstatus() == VMStatus.ImageLocked) { - ListUtils.nullSafeAdd(messages, VdcBllMessages.ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL.toString()); + ListUtils.nullSafeAdd(messages, VdcBllMessages.ACTION_TYPE_FAILED_VM_IMAGE_IS_LOCKED.toString()); returnValue = false; } else if (diskImageList != null) { for (Object object : diskImageList) { -- To view, visit http://gerrit.ovirt.org/8078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2edb7b8c946589f3bbad251d533704fe856bc175 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
