Darshan N has posted comments on this change. Change subject: tune: Set tuned profile based on environment variable. ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/39599/1/src/ovirt_host_deploy/constants.py File src/ovirt_host_deploy/constants.py: Line 132: class GlusterEnv(object): Line 133: ENABLE = 'GLUSTER/enable' Line 134: MONITORING_ENABLE = 'GLUSTER/monitoringEnable' Line 135: MONITORING_SERVER = 'GLUSTER/monitoringServer' Line 136: TUNED_PROFILE = 'GLUSTER/tunedProfile' > please turn this as none gluster specific. Done Line 137: Line 138: Line 139: @util.export Line 140: @util.codegen https://gerrit.ovirt.org/#/c/39599/1/src/plugins/ovirt-host-deploy/tune/tuned.py File src/plugins/ovirt-host-deploy/tune/tuned.py: Line 63 Line 64 Line 65 Line 66 Line 67 > should be: Nice idea! done. -- To view, visit https://gerrit.ovirt.org/39599 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2a6d69f52c4cbbc03cb14c7cb719f43846ef526 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
