Lior Vernia has posted comments on this change. Change subject: webadmin: show sriov icon on sriov enabled physical nics ......................................................................
Patch Set 10: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/36204/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java: Line 129: Line 130: // The purpose of this map is to keep the network parameters while moving the network from one nic to another Line 131: private final Map<String, NetworkParameters> networkToLastDetachParams; Line 132: Line 133: private Map<Guid, HostNicVfsConfig> nicToVfsConfig = new HashMap<>(); > You seem to only care about whether a NIC appeared in the returned collecti Never mind... Line 134: Line 135: private NetworkOperationFactory operationFactory; Line 136: private List<Network> allNetworks; Line 137: private final Map<String, DcNetworkParams> netTodcParams; -- To view, visit https://gerrit.ovirt.org/36204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b4e0765709fc713a67ef70c8dcd9b146babd24e Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
