Moti Asayag has posted comments on this change. Change subject: engine: introducing AddVfsConfigLabelCommand ......................................................................
Patch Set 11: Code-Review-1 (5 comments) https://gerrit.ovirt.org/#/c/36846/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddVfsConfigLabelCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddVfsConfigLabelCommand.java: Line 25: Line 26: @Override Line 27: protected boolean canDoAction() { Line 28: if (super.canDoAction()) { Line 29: return validate(getVfsConfigValidator().labelNotInVfsConfig(getLabel())); this can be simplified into a single return statement. Line 30: } Line 31: Line 32: return false; Line 33: } https://gerrit.ovirt.org/#/c/36846/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelVfsConfigCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelVfsConfigCommandBase.java: Line 3: import org.ovirt.engine.core.bll.context.CommandContext; Line 4: import org.ovirt.engine.core.common.action.VfsConfigLabelParameters; Line 5: import org.ovirt.engine.core.common.errors.VdcBllMessages; Line 6: Line 7: public abstract class LabelVfsConfigCommandBase extends VfsConfigCommandBase<VfsConfigLabelParameters> { name should be VfsConfigLabelCommandBase Line 8: Line 9: public LabelVfsConfigCommandBase(VfsConfigLabelParameters parameters) { Line 10: this(parameters, null); Line 11: } Line 16: Line 17: @Override Line 18: protected boolean canDoAction() { Line 19: if (super.canDoAction()) { Line 20: return validate(getVfsConfigValidator().settingSpecificNetworksAllowed()); sames as previous file Line 21: } Line 22: Line 23: return false; Line 24: } https://gerrit.ovirt.org/#/c/36846/11/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 547: ACTION_TYPE_FAILED_CANNOT_SET_SPECIFIC_NETWORKS=Cannot ${action} ${type}. All networks are allowed, cannot set specific network/label. Line 548: ACTION_TYPE_FAILED_NETWORK_ALREADY_IN_VFS_CONFIG=Cannot ${action} ${type}. Network ${networkName} already exists in network interface ${nicName} VFs configuration. Line 549: ACTION_TYPE_FAILED_NETWORK_NOT_IN_VFS_CONFIG=Cannot ${action} ${type}. Network ${networkName} doesn't exist in network interface ${nicName} VFs configuration. Line 550: ACTION_TYPE_FAILED_NETWORK_NOT_EXIST=Cannot ${action} ${type}. Network with id ${networkId} doesn't exist. Line 551: ACTION_TYPE_FAILED_LABEL_ALREADY_IN_VFS_CONFIG=Cannot ${action} ${type}. Label ${label} already exists in network interface ${nicName} VFs configuration. please add host name to the message. Line 552: Line 553: ERROR_CANNOT_RECOVERY_STORAGE_POOL_THERE_IS_ACTIVE_DATA_DOMAINS=Cannot recover Data Center with active Data Storage Domain in Data Center. Line 554: ERROR_CANNOT_DETACH_LAST_STORAGE_DOMAIN=Cannot remove the master Storage Domain from the Data Center without another active Storage Domain to take its place.\n\ Line 555: -Either activate another Storage Domain in the Data Center, or remove the Data Center. https://gerrit.ovirt.org/#/c/36846/11/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 564: UPDATE_HOST_NIC_VFS_CONFIG=The VFs configuration of network interface card ${NicName} was updated. Line 565: UPDATE_HOST_NIC_VFS_CONFIG_FAILED=Failed to update the VFs configuration of network interface card ${NicName}. Line 566: ADD_VFS_CONFIG_NETWORK=Network ${NetworkName} was added to the VFs configuration of network interface card ${NicName}. Line 567: ADD_VFS_CONFIG_NETWORK_FAILED=Failed to add ${NetworkName} to the VFs configuration of network interface card ${NicName}. Line 568: ADD_VFS_CONFIG_LABEL=Label ${Label} was added to the VFs configuration of network interface card ${NicName}. please add host name to the messages Line 569: ADD_VFS_CONFIG_LABEL_FAILED=Failed to add ${Label} to the VFs configuration of network interface card ${NicName}. Line 570: REMOVE_VFS_CONFIG_NETWORK=Network ${NetworkName} was removed from the VFs configuration of network interface card ${NicName}. Line 571: REMOVE_VFS_CONFIG_NETWORK_FAILED=Failed to remove ${NetworkName} from the VFs configuration of network interface card ${NicName}. Line 572: SYSTEM_DEACTIVATED_STORAGE_DOMAIN=Storage Domain ${StorageDomainName} (Data Center ${StoragePoolName}) was deactivated by system because it's not visible by any of the hosts. -- To view, visit https://gerrit.ovirt.org/36846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2fec58b2c5de89ae504b9057ab6781cf9a322df Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
