Moti Asayag has posted comments on this change. Change subject: engine: introducing AddVfsConfigNetworkCommand ......................................................................
Patch Set 11: (3 comments) https://gerrit.ovirt.org/#/c/36844/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddVfsConfigNetworkCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddVfsConfigNetworkCommand.java: Line 18: @Override Line 19: protected void executeCommand() { Line 20: super.executeCommand(); Line 21: Line 22: getVfsConfigDao().addNetwork(getVfsConfig().getId(), getNetworkId()); please replace getVfsConfigDao() with injecting the DAO. Line 23: setSucceeded(true); Line 24: } Line 25: Line 26: @Override Line 24: } Line 25: Line 26: @Override Line 27: protected boolean canDoAction() { Line 28: if (super.canDoAction()) { why not just: return super.canDoAction() && validate(getVfsConfigValidator().networkNotInVfsConfig(getNetworkId())); Line 29: return validate(getVfsConfigValidator().networkNotInVfsConfig(getNetworkId())); Line 30: } Line 31: Line 32: return false; https://gerrit.ovirt.org/#/c/36844/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkVfsConfigCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkVfsConfigCommandBase.java: Line 15: public NetworkVfsConfigCommandBase(VfsConfigNetworkParameters parameters, CommandContext commandContext) { Line 16: super(parameters, commandContext); Line 17: } Line 18: Line 19: @Override same comment as on previous file Line 20: protected boolean canDoAction() { Line 21: if (super.canDoAction()) { Line 22: return validate(getVfsConfigValidator().settingSpecificNetworksAllowed()) Line 23: && validate(getVfsConfigValidator().networkExists(getNetworkId())); -- To view, visit https://gerrit.ovirt.org/36844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied24ef5080716915eb9ef846d3c2f6bce398a4c0 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
