Federico Simoncelli has posted comments on this change.
Change subject: Use the real parent command for getParametersForTask
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 793: * @param parentCommandType parent command type for which the
task is created
Line 794: * @param parameters parameter of the creating command
Line 795: * @return
Line 796: */
Line 797: protected VdcActionParametersBase
getParametersForTask(VdcActionType parentCommandType,
Eventually we could clean this up and try to squash it in ConcreteCreateTask.
This method is not used anywhere else and the VdcActionType.Unknown logic
already belongs better to ConcreteCreateTask.
Line 798: VdcActionParametersBase parameters) {
Line 799: // If there is no parent command, the command that its type
Line 800: // will be stored in the DB for thr task is the one creating
the command
Line 801: if (parentCommandType == VdcActionType.Unknown) {
--
To view, visit http://gerrit.ovirt.org/8025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d84086a70e5aa78de3cb1a107d8773da25aa285
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
