Tomer Saban has posted comments on this change. Change subject: Samples: score by similar os for ksm ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/20033/3/plugins/examples/ksm_same_os_score.py File plugins/examples/ksm_same_os_score.py: Line 33: host_vms = connection.vms.list('host='+host_name) Line 34: Line 35: return host_vms Line 36: Line 37: def score_host(self, vm, host, connection): Is there a reason method "score_host" is public? Line 38: score = 0 Line 39: host_vms = self._get_vms(host.name, connection) Line 40: if not host_vms: Line 41: return (host.id, 0) -- To view, visit https://gerrit.ovirt.org/20033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfb359ecbd73a1f4a2520ac8a65b753449be55bd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> Gerrit-Reviewer: Tomer Saban <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
