Oved Ourfali has posted comments on this change. Change subject: engine: Add query for reporting host errata stats ......................................................................
Patch Set 9: Code-Review+2 (2 comments) https://gerrit.ovirt.org/#/c/39329/9/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetErrataCountsForHostQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetErrataCountsForHostQueryTest.java: Line 79: .getExceptionString()); Line 80: } Line 81: Line 82: @Test Line 83: public void noAvailableSystemErrata() { consider renaming to noAvailableHostErrata. Line 84: setupToReportErrata(Collections.<Erratum> emptyList()); Line 85: getQuery().executeQueryCommand(); Line 86: Line 87: assertNotNull(getQuery().getQueryReturnValue().getReturnValue()); Line 91: } Line 92: } Line 93: Line 94: @Test Line 95: public void availableSystemErrata() { consider renaming to availableHostErrata. Line 96: setupToReportErrata(expectedErrata()); Line 97: getQuery().executeQueryCommand(); Line 98: Line 99: ErrataCounts returnValue = (ErrataCounts) getQuery().getQueryReturnValue().getReturnValue(); -- To view, visit https://gerrit.ovirt.org/39329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaf39c5f1db9796babc97c22aad9754564f2d729 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
