Moti Asayag has posted comments on this change.

Change subject: core: add @PostConstruct to postConstruct methods
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39477/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java:

Line 92: import org.ovirt.engine.core.utils.linq.LinqUtils;
Line 93: import org.ovirt.engine.core.utils.transaction.TransactionMethod;
Line 94: import org.ovirt.engine.core.utils.transaction.TransactionSupport;
Line 95: 
Line 96: import javax.annotation.PostConstruct;
> no, would you like me to?
yes, since on the next patch someone will introduce a new change and eclipse 
will trigger the "Organize Imports", those lines will be changed, regardless of 
the content of the patch.

Please organize all the files in this patch. 10x.
Line 97: 
Line 98: /**
Line 99:  * This class adds a thinly provisioned VM over a template
Line 100:  */


-- 
To view, visit https://gerrit.ovirt.org/39477
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9cdd60457e60fa4c5257b0c0bc7e659bb7c704
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to