Allon Mureinik has posted comments on this change. Change subject: core: fix error message when adding unreachable SD (#853044) ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) minor phrasing comment in the commit message - please fix it when you rebase. .................................................... Commit Message Line 9: https://bugzilla.redhat.com/853044 Line 10: Line 11: The error message when adding an SD to a host that couldn't reach it was Line 12: "Internal oVirt engine error". This improves the message by both Line 13: propagating the actual error through the backend, and generalzes the s/generalzes/generalizing/ Line 14: message wording so the solution is accurate in this case. Line 15: Line 16: Change-Id: Ia1007ce4678576181563f77e39bd8b83b8dd0752 -- To view, visit http://gerrit.ovirt.org/7968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1007ce4678576181563f77e39bd8b83b8dd0752 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
