Sahina Bose has posted comments on this change.

Change subject: engine: Added username to georep session
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/39448/1/packaging/dbscripts/gluster_georep_sp.sql
File packaging/dbscripts/gluster_georep_sp.sql:

Line 12:                                                       
v_slave_host_name VARCHAR(50),
Line 13:                                                       
v_slave_host_uuid UUID,
Line 14:                                                       
v_slave_volume_name VARCHAR(50),
Line 15:                                                       
v_slave_volume_id UUID,
Line 16:                                                       v_status 
VARCHAR(50),
> I see that user name in users is character varying(255)
will change to match
Line 17:                                                       v_user_name 
VARCHAR(100))
Line 18: RETURNS VOID
Line 19: AS $procedure$
Line 20: BEGIN


https://gerrit.ovirt.org/#/c/39448/1/packaging/dbscripts/upgrade/03_06_1160_add_username_column_to_georep_session.sql
File 
packaging/dbscripts/upgrade/03_06_1160_add_username_column_to_georep_session.sql:

Line 1: select fn_db_add_column('gluster_georep_session', 'user_name', 
'VARCHAR(100)');
> I see that user name in users is character varying(255)
will change to match


-- 
To view, visit https://gerrit.ovirt.org/39448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5015c11891600c8e44710fc45c43cfcca8da941c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to