Roy Golan has posted comments on this change.

Change subject: userportal,webadmin: Run once: unable to attach floppy disks 
(#855579)
......................................................................


Patch Set 1: (1 inline comment)

minor comment

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 374:      *            - The storage domain Id we want to get the file 
list from.
Line 375:      * @param IsoStoragePoolId
Line 376:      *            - The storage pool Id we want to get the file list 
from.
Line 377:      * @return List of Iso file fetched from DB, if parameter is 
invalid returns an empty list.
Line 378:      */
add to FileTypeExtention java doc
Line 379:     public List<RepoFileMetaData> 
getCachedIsoListByStoragePoolAndDomainId(Guid isoStoragePoolId, Guid 
isoStorageDomainId, FileTypeExtension fileTypeExtension) {
Line 380:         List<RepoFileMetaData> fileListMD = new 
ArrayList<RepoFileMetaData>();
Line 381:         // Check validation of parameters.
Line 382:         if (isoStorageDomainId != null && isoStoragePoolId != null && 
VmRunHandler.getInstance().findActiveISODomain(isoStoragePoolId) != null) {


--
To view, visit http://gerrit.ovirt.org/7965
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11d2f7caf8f75efd83e3b557c9e305baebcef2ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to