Moran Goldboim has posted comments on this change.

Change subject: tools: Fix default port (BZ857480)
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File src/engine-iso-uploader.py
Line 785:                                                      NUMERIC_VDSM_ID)
Line 786:                                     # Force oVirt Engine to refresh 
the list of files in the ISO domain
Line 787:                                     if id is not None:
Line 788:                                         self.refresh_iso_domain(id)
Line 789:                                     logging.info(_("%s uploaded 
successfully") % file)
indeed gives a better feeling
Line 790:                             else:
Line 791:                                 logging.error(_('There is not enough 
space in %s (%s bytes) for %s (%s bytes)' %
Line 792:                                               (path, dir_size, file, 
file_size)))
Line 793:                         except Exception, e:


--
To view, visit http://gerrit.ovirt.org/8007
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idab93219597d8199ffb79a0c7c664c6369c0416a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to