Omer Frenkel has posted comments on this change. Change subject: core: vmsMonitoring - save info to be sooner ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/39406/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-31 17:48:49 +0300 Line 4: Commit: Omer Frenkel <ofren...@redhat.com> Line 5: CommitDate: 2015-03-31 17:48:49 +0300 Line 6: Line 7: core: vmsMonitoring - save info to be sooner > to be sooner what?:) earlier is better? or should i totally rephrase it? Line 8: Line 9: the new structure of the host-vms monitoring caused the save vms info to Line 10: db to be called later in the cycle than it used to be. Line 11: https://gerrit.ovirt.org/#/c/39406/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 167: * this filtering. Line 168: */ Line 169: private void refreshVmStats() { Line 170: for (Pair<VM, VmInternalData> pair : monitoredVms) { Line 171: // TODO filter out migratingTo VMs if no action is taken on them > I wonder about this TODO....don't we have a mess right now? we always have a mess.. this TODO is about optimization: we ignore vms in migratingTo, so we could filter them out to begin with, just need to make sure before we do this, hence the TODO. Roy please correct me if im wrong.. Line 172: if (tryLockVmForUpdate(pair)) { Line 173: VmAnalyzer vmAnalyzer = new VmAnalyzer( Line 174: pair.getFirst(), Line 175: pair.getSecond(), -- To view, visit https://gerrit.ovirt.org/39406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e69b0ba20588db55bb40e9ba6ca5472c3efe687 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
