Tomer Saban has posted comments on this change. Change subject: webadmin: Added range values to QoS error message. ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/35318/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java: Line 16: Line 17: /* All Throughput values are in MiBs per second */ Line 18: Line 19: @ConfiguredRange(min = 0, maxConfigValue = ConfigValues.MaxThroughputUpperBoundQosValue, Line 20: message = "ACTION_TYPE_FAILED_QOS_STORAGE_OUT_OF_RANGE_VALUES") > no need for this change It is needed because the QoS for CPU is different from the one for the storage. Their range is different(You can see that I didn't add the range for the storage like I did for the cpu, see AppErrors). Line 21: private Integer maxThroughput; Line 22: Line 23: @ConfiguredRange(min = 0, maxConfigValue = ConfigValues.MaxReadThroughputUpperBoundQosValue, Line 24: message = "ACTION_TYPE_FAILED_QOS_STORAGE_OUT_OF_RANGE_VALUES") https://gerrit.ovirt.org/#/c/35318/7/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1138: Line 1139: ACTION_TYPE_FAILED_TAG_ID_REQUIRED=Cannot ${action} ${type}. Tag ID is required. Line 1140: Line 1141: ACTION_TYPE_FAILED_QOS_CPU_OUT_OF_RANGE_VALUES=Cannot ${action} ${type}. Values are out of range\n(Legal range is: ${range}). Line 1142: ACTION_TYPE_FAILED_QOS_STORAGE_OUT_OF_RANGE_VALUES=Cannot ${action} ${type}. Values are out of range. > so why do we need an extra key for STORAGE type Because it's range is different than the one for the CPU. Line 1143: ACTION_TYPE_FAILED_QOS_STORAGE_POOL_NOT_EXIST=Cannot ${action} ${type}. Invalid data center. Line 1144: ACTION_TYPE_FAILED_QOS_STORAGE_POOL_NOT_CONSISTENT=Cannot ${action} ${type}. Cannot change QoS data center. Line 1145: Line 1146: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES=Cannot ${action} ${type}. All three values are needed in order to define QoS on each network directions. -- To view, visit https://gerrit.ovirt.org/35318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0e1b2ef97624b6b0f3c9c95e7a09e15561a458b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
