Lior Vernia has posted comments on this change. Change subject: webadmin: add showErrorDialog property to runMultipleAction ......................................................................
Patch Set 6: (4 comments) https://gerrit.ovirt.org/#/c/37722/6/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java: Line 487: * @param callback The callback to call after the operation happens. Line 488: * @param state A state object. Line 489: * @param showErrorDialog Should we show an error dialog? Line 490: */ Line 491: public void runMultipleAction(final VdcActionType actionType, Why is this overload needed? Is there any place in the code invoking with both state and showErrorDialog specified? Line 492: final List<VdcActionParametersBase> parameters, Line 493: final IFrontendMultipleActionAsyncCallback callback, Line 494: final Object state, Line 495: final boolean showErrorDialog) { Line 509: final IFrontendMultipleActionAsyncCallback callback, Line 510: final Object state) { Line 511: runMultipleAction(actionType, parameters, false, callback, state, true); Line 512: } Line 513: ? :) Line 514: Line 515: /** Line 516: * RunMultipleActions without passing state. Line 517: * @param actionType The type of action to perform. Line 519: */ Line 520: public void runMultipleAction(final VdcActionType actionType, Line 521: final List<VdcActionParametersBase> parameters, Line 522: final IFrontendMultipleActionAsyncCallback callback) { Line 523: runMultipleAction(actionType, parameters, callback, null, true); Why not leave unedited and call the 4-parameter overload? Is there overload ambiguity? Line 524: } Line 525: Line 526: /** Line 527: * RunMultipleActions without passing in a callback or state. Line 529: * @param parameters The parameters of the action. Line 530: */ Line 531: public void runMultipleAction(final VdcActionType actionType, Line 532: final List<VdcActionParametersBase> parameters) { Line 533: runMultipleAction(actionType, parameters, null, null, true); Same question. Line 534: } Line 535: Line 536: /** Line 537: * RunMultipleActions without passing state. -- To view, visit https://gerrit.ovirt.org/37722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I703c95dd2c8bfc2ff3cc997019dcd15fd671d234 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
