Yair Zaslavsky has posted comments on this change.
Change subject: core: check host time-drift in getVdsStat(#848862)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 335: Date hostDate = AssignDatetimeValue(xmlRpcStruct,
VdsProperties.hostDatetime);
Line 336: if (hostDate != null) {
Line 337: Long timeDrift =
Line 338:
TimeUnit.MILLISECONDS.toSeconds(Math.abs(hostDate.getTime() -
System.currentTimeMillis()));
Line 339: if (timeDrift > maxTimeDriftAllowed) {
Eli , now that I see the convertion to seconds, why not keep the time drift
allowed value at db in milseconds and save the conversion?
Line 340: AuditLogableBase logable = new
AuditLogableBase(vds.getId());
Line 341: logable.AddCustomValue("Actual",
timeDrift.toString());
Line 342: logable.AddCustomValue("Max",
maxTimeDriftAllowed.toString());
Line 343: AuditLogDirector.log(logable,
AuditLogType.VDS_TIME_DRIFT_ALERT);
--
To view, visit http://gerrit.ovirt.org/7830
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1f38149c0a7fb1d6e1627e86b1a3c231352e1a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
