Yair Zaslavsky has posted comments on this change. Change subject: core: adding values to engine-config(#848862) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/tools/engine-config/src/main/resources/engine-config.properties Line 219: AllowClusterWithVirtGlusterEnabled.description="Allows to create a Cluster with both Virt and Gluster services enabled" Line 220: AllowClusterWithVirtGlusterEnabled.validValues=true,false Line 221: EnableMACAntiSpoofingFilterRules.description="Indicates if Network Filtering should be enabled or not." Line 222: EnableMACAntiSpoofingFilterRules.validValues=true,false Line 223: EnableHostTimeDrift.description="Enables hosts to have diffrent time from engine" Is this correct? IMHO, if the value of EnableHostTImeDrift is true, it doesn't mean that we allow the host to have a different time, but that we will check for time drift. Line 224: EnableHostTimeDrift.validValues=true,false Line 225: HostTimeDriftInSec.type=Integer Line 226: HostTimeDriftInSec.description="Allowed time drift between any Host and Engine" -- To view, visit http://gerrit.ovirt.org/7829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e73ba5817e164ef06dd554d7eaa3589d0da3f99 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
