Liran Zelkha has posted comments on this change. Change subject: core: Make DAOs injectable ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/38505/7/backend/manager/modules/dal/pom.xml File backend/manager/modules/dal/pom.xml: > I'm not sure how these new artifacts are used in this patch. Required by Spring for the @Configuration classes. ORM was removed. Line 1: <?xml version="1.0"?> Line 2: <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> Line 3: <modelVersion>4.0.0</modelVersion> Line 4: <parent> https://gerrit.ovirt.org/#/c/38505/7/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java: Line 287: private <T extends DAO> T getDao(Class<T> daoType) { Line 288: for (DAO dao : daos) { Line 289: if (daoType.isAssignableFrom(dao.getClass())) { Line 290: if (dao instanceof BaseDAODbFacade) { Line 291: initBaseDAO((BaseDAODbFacade) dao); > I still be able to see this line :/ Done Line 292: } Line 293: return (T) dao; Line 294: } Line 295: } -- To view, visit https://gerrit.ovirt.org/38505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic426126d690ab6dedb49ef6b67deeba67661d031 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
