Greg Sheremeta has posted comments on this change. Change subject: engine: Add query for reporting system errata stats ......................................................................
Patch Set 4: (1 comment) My only concern is one of English. When you refer to "statistics", it looks like we're only tracking counts here. "Statistics" is a broader term that includes other measures. Will there be other measures in the future? If not, I'd lean towards changing use of the word "statistics" to "counts". https://gerrit.ovirt.org/#/c/39329/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ErrataStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ErrataStatistics.java: Line 36: return total; Line 37: } Line 38: Line 39: /** Line 40: * The class represents a statistics between the errata type {@see ErrataType} to the statistics of its severity. This sentence doesn't make sense -- are you missing the word "Map" in here somewhere? Line 41: * Line 42: * @param <E> Line 43: * The errata type Line 44: */ -- To view, visit https://gerrit.ovirt.org/39329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idaf39c5f1db9796babc97c22aad9754564f2d729 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
