Allon Mureinik has posted comments on this change. Change subject: core: Renamed AddVmDynamic() to addVmDynamic() ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Don't you prefer handling all these methods (addVmDynamic, addVmStatic, etc.) in a single patch? .................................................... Commit Message Line 3: AuthorDate: 2012-09-12 19:58:29 -0700 Line 4: Commit: Sharad Mishra <snmis...@linux.vnet.ibm.com> Line 5: CommitDate: 2012-09-12 20:00:22 -0700 Line 6: Line 7: core: Renamed AddVmDynamic() to addVmDynamic() Please add the class' name here too. Line 8: Line 9: To conform to java style. Line 10: Line 11: Change-Id: Iaca090a5d0e66b79c2b8c4e90c335aef6a041fc7 -- To view, visit http://gerrit.ovirt.org/7972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaca090a5d0e66b79c2b8c4e90c335aef6a041fc7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
