Yair Zaslavsky has posted comments on this change. Change subject: engine: Firewall configuration modified to support virt and gluster iptable rules. ......................................................................
Patch Set 5: I would prefer that you didn't submit this 1. This is not the place to add new configuration to vdc_options. 2. Use helper pgsql functions to do that Proper location is - ovirt-engine/backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql - If these are new values, add them at the "add section" of the file. -- To view, visit http://gerrit.ovirt.org/7244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a5958e870d3315316a59e1038101b2511bf8815 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
