Yair Zaslavsky has posted comments on this change. Change subject: core: Refactored roles to Role. ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java Line 24: import org.ovirt.engine.core.compat.StringHelper; Line 25: import org.ovirt.engine.core.compat.StringFormat; Line 26: import org.ovirt.engine.core.compat.TimeSpan; Line 27: Line 28: @Entity Why is this included here? Maybe I missed it, but I dont see any usage of Role... Line 29: @Table(name = "vm_pools") Line 30: @TypeDef(name = "guid", typeClass = GuidType.class) Line 31: public class vm_pools extends IVdcQueryable implements INotifyPropertyChanged, Serializable { Line 32: -- To view, visit http://gerrit.ovirt.org/7229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca1616161e2d1bbf3eae5d440fdf8209cafea34 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches