Moti Asayag has posted comments on this change.
Change subject: core: notify user about broken domain tasks (#753591)
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SetStoragePoolStatusCommand.java
Line 50: }
Line 51:
Line 52: };
Line 53:
auditLogableBase.setStorageDomain(getStorageDomain());
Line 54: auditLogableBase.setJobId(taskId);
You can use log(AuditLogableBase auditLogable, AuditLogType logType) and save
the creation of new class, e.g.:
AuditLogableBase auditLogableBase = new AuditLogableBase();
...
AuditLogDirector.log(auditLogableBase, AuditLogType.STORAGE_DOMAIN_TASKS_ERROR);
Line 55: AuditLogDirector.log(auditLogableBase);
Line 56: }
Line 57: }
Line 58: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 594:
Line 595: // Authentication
Line 596: USER_ACCOUNT_DISABLED_OR_LOCKED(1100,
AuditLogTimeInterval.HOUR.getValue()),
Line 597: USER_ACCOUNT_PASSWORD_EXPIRED(1101,
AuditLogTimeInterval.HOUR.getValue()),
Line 598: STORAGE_DOMAIN_TASKS_ERROR(1102),
It doesn't look like the correct place to put this message, maybe near the
Storage related auditlog types ?
Line 599:
Line 600: VDS_ALERT_FENCING_IS_NOT_CONFIGURED(9000),
Line 601: VDS_ALERT_FENCING_TEST_FAILED(9001),
Line 602: VDS_ALERT_FENCING_OPERATION_FAILED(9002),
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 516: RELOAD_CONFIGURATIONS_SUCCESS=System Configurations reloaded
successfully.
Line 517: RELOAD_CONFIGURATIONS_FAILURE=System Configurations failed to reload.
Line 518: USER_ACCOUNT_DISABLED_OR_LOCKED=User ${UserName} cannot login, as it
got disabled or locked. Please contact the system administrator.
Line 519: USER_ACCOUNT_PASSWORD_EXPIRED=User ${UserName} cannot login, as the
user account password has expired. Please contact the system administrator.
Line 520: STORAGE_DOMAIN_TASKS_ERROR=Storage domain is down while there are
tasks running on it. These tasks may fail.
s/domain/Domain
Line 521: IMPORTEXPORT_IMPORT_VM_INVALID_INTERFACES=While importing VM
${VmName}, the Network/s ${Networks} were found to be Non-VM Networks or do not
exist in Cluster. Network Name was not set in the Interface/s ${Interfaces}.
Line 522: IMPORTEXPORT_IMPORT_TEMPLATE_INVALID_INTERFACES=While importing
Template ${VmTemplateName}, the Network/s ${Networks} were found to be Non-VM
Networks or do not exist in Cluster. Network Name was not set in the
Interface/s ${Interfaces}.
Line 523: VDS_SET_NON_OPERATIONAL_VM_NETWORK_IS_BRIDGELESS=Host ${VdsName} does
not comply with the cluster ${VdsGroupName} networks, the following VM networks
are bridgeless: '${Networks}'
Line 524: # Gluster Messages
--
To view, visit http://gerrit.ovirt.org/7957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b6239668eece2be39b96c9bd360af2bd310a3b0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
