Yevgeny Zaspitsky has posted comments on this change. Change subject: core: Make DAOs injectable ......................................................................
Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/38505/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java: Line 274: Class<T> daoType = (Class<T>) mapEntityToDao.get(entityClass); Line 275: return getDao(daoType); Line 276: } Line 277: Line 278: public void initBaseDAO(BaseDAODbFacade dao) { > True. I plan a future patch to fix DbFacade, Dialect, Template and DbFacade I'd prefer that patch be merged into this one. Line 279: dao.setTemplate(jdbcTemplate); Line 280: dao.setDialect(dbEngineDialect); Line 281: dao.setDbFacade(this); Line 282: } Line 285: public > 1. Fixed. Could this method be private? Line 288: initBaseDAO > We use CDI in runtime (which supports the @Any annotation and injects all t 1. I'm not sure I know why do we use Spring in tests whereas we do not use that in run-time. 2. making pleased Spring based tests causing us change our non-Spring based run-time code. -- To view, visit https://gerrit.ovirt.org/38505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic426126d690ab6dedb49ef6b67deeba67661d031 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
