Tal Nisan has posted comments on this change. Change subject: webadmin: DataCenterStorageListModel update availability refactor. ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/38585/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java: Line 758: getAttachStorageCommand().setIsExecutionAllowed(!getEntity().isLocal()); Line 759: } Line 760: Line 761: boolean isMasterPresents = false; Line 762: boolean isISOPresents = false; s/presents/present if we're at it :) Line 763: boolean isBackupPresents = false; Line 764: for (StorageDomain domain : items) { Line 765: if (isMasterDomain(domain)) { Line 766: isMasterPresents = true; Line 759: } Line 760: Line 761: boolean isMasterPresents = false; Line 762: boolean isISOPresents = false; Line 763: boolean isBackupPresents = false; Same here Line 764: for (StorageDomain domain : items) { Line 765: if (isMasterDomain(domain)) { Line 766: isMasterPresents = true; Line 767: } else if (domain.getStorageDomainType() == StorageDomainType.ISO) { Line 793: StorageDomain.class, Line 794: VdcActionType.DeactivateStorageDomainWithOvfUpdate)); Line 795: } Line 796: Line 797: private boolean isMasterDomain(StorageDomain domain) { The check is also concerning the status so this should probably be named "isDomainMasterAndActive" Line 798: return domain.getStorageDomainType() == StorageDomainType.Master && domain.getStatus() == StorageDomainStatus.Active; Line 799: } Line 800: Line 801: @Override -- To view, visit https://gerrit.ovirt.org/38585 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88abe054994257e2d3bd781d4d3b53aece75cd2c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
