Ori Liel has posted comments on this change. Change subject: core: Introduce SingleAgentFenceActionExecutor ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38358/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java: Line 24: SingleAgentFenceActionExecutor > There's not a redundancy: Your explanation clarifies things. I understand your approach, and I think it's a good approach. But I'm not happy about the names. * FenceAgentExecutor * SingleAgentFenceActionExecutor * ConcurrentAgentFenceActionExecutor * HostFenceActionExecutor 1) FenceAgeneExecutor vs SingleAgentFenceActionExecutor - very confusing IMO 2) HostFenceActionExecutor vs FenceAgentExecutor - again, very confusing. Plus, all 'executors' always operate on a certain host, so naming one of them "Host..." seems redundant, How can we keep your operation-level-oriented approach, but have meaningful names? I propose: * FenceManager (highest level) * SingleAgentFenceActionsManager * ConcurrentAgentsFenceActionsManager * FenceAgentExecutor (lowest level) Still a bit confusing, but in my opinion better. What do you think? -- To view, visit https://gerrit.ovirt.org/38358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95958b4821fa8f55ee8913e926f9528ae56e20e8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
