Greg Sheremeta has uploaded a new change for review.
Change subject: engine: fixed NPE findbugs introduced in 1bfc9d0
......................................................................
engine: fixed NPE findbugs introduced in 1bfc9d0
Change-Id: Ib125a84415d84b2d4cda661b04719b5f5fa470d8
Signed-off-by: Greg Sheremeta <gsher...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/39301/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
index 0de4946..8148caa 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
@@ -349,7 +349,8 @@
try {
failedRemoveCinderDisks = future.get().getActionReturnValue();
} catch (InterruptedException | ExecutionException e) {
- failedRemoveCinderDisks.addAll(cinderDisks);
+ // TODO commented out next line because it can only ever be
null here
+ // failedRemoveCinderDisks.addAll(cinderDisks);
log.error("Exception", e);
}
}
--
To view, visit https://gerrit.ovirt.org/39301
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib125a84415d84b2d4cda661b04719b5f5fa470d8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
