Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: changed csh to use per-locale mapping ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/39297/2/backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/ContextSensitiveHelpMappingServlet.java File backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/ContextSensitiveHelpMappingServlet.java: Line 131: Line 132: File file = new File(configPath, jsonFile); Line 133: if (file.exists() && file.canRead()) { Line 134: BufferedReader reader = null; Line 135: try { > Do Java 7 construct, to be sure the file reader is closed properly? Done Line 136: reader = new BufferedReader(new FileReader(file.getAbsolutePath())); Line 137: nodes.add(mapper.readTree(reader)); Line 138: log.info("Successfully read CSH mapping file '{}'", file.getAbsolutePath()); Line 139: } Line 196: for (File dir : manualDir.listFiles()) { Line 197: if (dir.isDirectory() && dir.canRead()) { Line 198: String name = dir.getName(); Line 199: // fancy locale name detection Line 200: if (name.length() == 5 && name.indexOf("-") == 2) { //$NON-NLS-1$ > at least do a regex of like \w\w\-\w\w or something, since I can have a fil Done Line 201: locales.add(name); Line 202: } Line 203: } Line 204: } -- To view, visit https://gerrit.ovirt.org/39297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f854a9d7034d436730a4e82c88963a854e2c2b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
