Ondřej Macháček has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/37886/12/backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/core/config.properties File backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/core/config.properties: Line 1: config.package.name = @EXT_TESTTOOL_PACKAGE_NAME@ Line 2: config.package.version = @EXT_TESTTOOL_PACKAGE_VERSION@ Line 3: config.package.displayName = @EXT_TESTTOOL_PACKAGE_DISPLAY_NAME@ Alon, do I understand correctly, that these varibales should be rewritten in Makefile in ".in" section, using sed? -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
