Sahina Bose has posted comments on this change. Change subject: engine : refactoring vds commands ......................................................................
Patch Set 6: (4 comments) https://gerrit.ovirt.org/#/c/39250/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java: Line 45: can you do this if getGlusterVolumeId is null? wouldn't the setGlusterVolumeId be called in the constructor already? https://gerrit.ovirt.org/#/c/39250/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteGlusterVolumeGeoRepSessionVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteGlusterVolumeGeoRepSessionVDSCommand.java: Line 19: (). getParameters().getUserName() ? https://gerrit.ovirt.org/#/c/39250/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepConfigListVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepConfigListVDSCommand.java: Line 20: } Line 21: Line 22: @Override Line 23: protected void executeVdsBrokerCommand() { Line 24: result = getBroker().glusterVolumeGeoRepConfigList(getParameters().getVolumeName(), getParameters().getSlaveHost(), getParameters().getSlaveVolume(), null); getParameters().getUserName() ? Line 25: proceedProxyReturnValue(); Line 26: List<GlusterGeoRepSessionConfiguration> sessionConfigs = result.getSessionConfig(); Line 27: setReturnValue(sessionConfigs); Line 28: } https://gerrit.ovirt.org/#/c/39250/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterVolumeGeoRepSessionVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterVolumeGeoRepSessionVDSCommand.java: Line 19: shouldn't this be getParameters().getUserName? -- To view, visit https://gerrit.ovirt.org/39250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6354afa4e543fc6e3a8fe669f37ffaee400c53 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
