Martin Peřina has posted comments on this change. Change subject: core: Introduce HostFenceActionExecutor ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38965/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/HostFenceActionExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/HostFenceActionExecutor.java: Line 85: PowerStatus.UNKNOWN, Line 86: "Invalid fence agent specified."); Line 87: } Line 88: Line 89: List<FenceAgent> fenceAgents = new ArrayList<>(); > why not instead of 3 lines just one? Done Line 90: fenceAgents.add(fenceAgent); Line 91: return fence(FenceActionType.STATUS, fenceAgents); Line 92: } Line 93: -- To view, visit https://gerrit.ovirt.org/38965 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15bbc7e4a7a297173d3486394ac53587306078b1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
