Daniel Erez has posted comments on this change. Change subject: core: Support remove of VM with Cinder disks ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/39230/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java: Line 63: failedRemoveCinderDisks no need to initialize Line 351: failedRemoveCinderDisks maybe we can just return this list instead of keeping it as a class member. -- To view, visit https://gerrit.ovirt.org/39230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bf8b7e54542bd0673c5c26e98fbe0335d74a79b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
